Skip to content

dnsdist: Optionally send 'verbose' messages to a file, and log them at 'DEBUG' level otherwise #11668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Jun 1, 2022

Short description

This pull request:

  • sends 'verbose' message at syslog's 'debug' level instead of 'info'
  • adds a new configuration option, setVerboseLogDestination(dest) which, when used at configuration time, redirects these messages to a file instead of sending to the standard output and/or syslog.

This is useful to be able to log these messages separately when investigating an issue, without flooding the system logs.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jun 1, 2022
@rgacogne rgacogne requested a review from Habbie June 1, 2022 15:02
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit, otherwise approved

Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
Co-authored-by: Peter van Dijk <peter.van.dijk@powerdns.com>
@rgacogne rgacogne requested a review from Habbie June 3, 2022 08:57
@rgacogne rgacogne merged commit 551ca3e into PowerDNS:master Jun 3, 2022
@rgacogne rgacogne deleted the ddist-verbose-logging branch June 3, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants