Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SuffixMatchTree::getBestMatch() to get the name that matched #11698

Merged
merged 2 commits into from
Jun 22, 2022

Conversation

rgacogne
Copy link
Member

Short description

This PR adds a new method, SuffixMatchTree::getBestMatch() making it possible to know against which name from a SuffixMatchTree we matched.
It also adds lua bindings for that method in dnsdist, as well as bindings for a few more DNSName methods.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jun 15, 2022
@rgacogne rgacogne changed the title Implement SuffixMatchTree::getBestMatch() to get the name that matched Implement SuffixMatchTree::getBestMatch() to get the name that matched Jun 15, 2022
@rgacogne
Copy link
Member Author

CI failure is unrelated (Google is not being cooperative with regard to ALIAS resolution).

@rgacogne rgacogne merged commit 6b3d3ff into PowerDNS:master Jun 22, 2022
@rgacogne rgacogne deleted the ddist-more-name-bindings branch June 22, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants