Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Compute backend latency earlier, to avoid internal latency #11707

Merged
merged 4 commits into from
Jun 22, 2022
Merged

dnsdist: Compute backend latency earlier, to avoid internal latency #11707

merged 4 commits into from
Jun 22, 2022

Conversation

rgacogne
Copy link
Member

Short description

Also properly report the latency as TCP when forwaring a query received over UDP to TCP-only, DoT and DoH backends.
And export the TCP latency in the prometheus and API metrics.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
dnsdist: Compute backend latency earlier, to avoid internal latency
cd66377 
Also properly report the latency as TCP when forwaring a query received
over UDP to TCP-only, DoT and DoH backends.
Exports the TCP latency in the prometheus and API metrics.
@rgacogne
dnsdist: Test the TCP latency in our regression tests
7f7167e
@rgacogne
dnsdist: Properly handle TCP latencies for DoH backends as well
0c51513
@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jun 17, 2022
Habbie
Habbie requested changes Jun 22, 2022
View reviewed changes
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine except for the stray cerr

pdns/dnsdist.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne requested a review from Habbie June 22, 2022 08:59
@rgacogne rgacogne merged commit 9945d41 into PowerDNS:master Jun 22, 2022
@rgacogne rgacogne deleted the ddist-latencies branch June 22, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Habbie Habbie Habbie approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @Habbie