dnsdist: Implement a limit of concurrent connections to a backend #11713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
force-pushed
the
ddist-upstream-conn-limit
branch
from
6fe26aa to
ed3fe8c
Compare
|
Rebased to fix a conflict. |
rgacogne
force-pushed
the
ddist-upstream-conn-limit
branch
from
ed3fe8c to
c8cfeda
Compare
|
Rebased to fix a conflict. |
Habbie
approved these changes
Jun 24, 2022
…dead By remember that a connection is no longer usable when we notice that, we prevent a case where we could pretend that it will be usable when it has finished processing the current queries and responses, which is not true.
rgacogne
force-pushed
the
ddist-upstream-conn-limit
branch
from
c8cfeda to
a34f264
Compare
|
And rebased again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a new option to limit the number of TCP connections to a backend. When that limit is reached, no new connection to that backend will be opened, and queries routed to that backend will fail, until the number of connections goes back below that limit.
It also introduces a new metric for that value, and a counter indicating how often it was reached.
Finally it slightly improves the way we are reusing TCP connections by detaching them from the incoming connection a bit earlier in the process, and immediately releasing idle connections when no longer need them.
Checklist
I have: