Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix the number of concurrent queries on a backend TCP conn #11718

Merged

Conversation

rgacogne
Copy link
Member

Short description

When we are in the process of sending a query to the backend, that query is no longer accounted in the "queued" queries nor it is in the "queued" responses, but we need to take it into account.
Otherwise we might be sending two concurrent queries to a backend that does not support out-of-order processing (increasing our latency), or even worse to one that does not support pipelining.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

When we are in the process of sending a query to the backend, that
query is no longer accounted in the "queued" queries nor it is in
the "queued" responses, but we need to take it into account.
Otherwise we might be sending two concurrent queries to a backend
that does not support out-of-order processing (increasing our
latency), or even worse to one that does not support pipelining.
@rgacogne rgacogne merged commit 7688ffd into PowerDNS:master Jun 24, 2022
@rgacogne rgacogne deleted the ddist-fix-backend-concurrent-conns branch June 24, 2022 11:54
@rgacogne rgacogne mentioned this pull request Mar 6, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants