Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Do not keep the mplexer created for the initial health-check around #11844

Merged

Conversation

rgacogne
Copy link
Member

Short description

We no longer need it after that initial health-check round so it is only wasting (a very small amount of) memory and one file descriptor at that point.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

… around

We do not need after that initial health-check round so it is only wasting
(a very small amount of) memory and one file descriptor at that point.
@Habbie
Copy link
Member

Habbie commented Aug 16, 2022

CI failure is unrelated

@rgacogne rgacogne merged commit 371fa48 into PowerDNS:master Aug 16, 2022
@rgacogne rgacogne deleted the ddist-destroy-initial-health-mplexer branch August 16, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants