dnsdist: Only call getsockname() once per incoming DoH connection #11851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code is calling h2o_socket_getpeername() and h2o_socket_getsockname() once per DoH _query_, and while the former is cheap because h2o caches the result for us, the latter is actually expensive, so this code caches both values so that we only retrieve them once per DoH connection.
Habbie
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The current code is calling
h2o_socket_getpeername()andh2o_socket_getsockname()once per DoH query, and while the former is cheap because h2o caches the result for us, the latter is actually expensive, so this code caches both values so that we only retrievethem once per DoH connection.
Checklist
I have: