Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Make recording queries/responses in the ringbuffers optional #11883

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

rgacogne
Copy link
Member

Short description

In some setups where grepq, top* and the dynamic blocks are not used, inserting queries and/or responses into the ring buffers is not worth it, as it involves (small) CPU and memory costs.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one unrelated question (in a comment), one related question: should this deprecate setRingBuffersLockRetries?

@rgacogne
Copy link
Member Author

rgacogne commented Sep 1, 2022

Looks good, one unrelated question (in a comment), one related question: should this deprecate setRingBuffersLockRetries?

Yes! On it.

@rgacogne rgacogne merged commit 33161bd into PowerDNS:master Sep 2, 2022
@rgacogne rgacogne deleted the ddist-optional-rings branch September 2, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants