dnsdist: Add Lua helpers to look into the content of DNS payloads #12022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
force-pushed
the
ddist-dnsparser-helpers
branch
from
1edb5ca to
236fc45
Compare
7 tasks
chbruyand
reviewed
Oct 6, 2022
| print(overlay.qname) | ||
| print(overlay.qtype) | ||
| print(overlay.qclass) | ||
| local count = overlay:getRecordsCountInSection(1) |
There was a problem hiding this comment.
Suggested change
| local count = overlay:getRecordsCountInSection(1) | |
| local count = overlay:getRecordsCountInSection(DNSSection.Answer) |
| .. method:: DNSPacketOverlay:getRecordsCountInSection(section) -> int | ||
|
|
||
| Returns the number of records in the ANSWER (1), AUTHORITY (2) and | ||
| ADDITIONAL (3) section of this packet. The number of records in the |
There was a problem hiding this comment.
Suggested change
| ADDITIONAL (3) section of this packet. The number of records in the | |
| ADDITIONAL (3) :ref:`DNSSection` of this packet. The number of records in the |
| luaCtx.registerMember<dnsheader(dnsdist::DNSPacketOverlay::*)>(std::string("dh"), [](const dnsdist::DNSPacketOverlay& overlay) { return overlay.d_header; }); | ||
|
|
||
| luaCtx.registerFunction<uint16_t (dnsdist::DNSPacketOverlay::*)(uint8_t) const>("getRecordsCountInSection", [](const dnsdist::DNSPacketOverlay& overlay, uint8_t section) -> uint16_t { | ||
| if (section > 3) { |
There was a problem hiding this comment.
Suggested change
| if (section > 3) { | |
| if (section > DNSResourceRecord::ADDITIONAL) { |
If it doesn't need an extra include ?
pdns/dnsdistdist/dnsdist-lua-ffi.cc
Outdated
|
|
||
| uint16_t dnsdist_ffi_dnspacket_get_records_count_in_section(const dnsdist_ffi_dnspacket_t* packet, uint8_t section) | ||
| { | ||
| if (packet == nullptr || section > 3) { |
There was a problem hiding this comment.
Suggested change
| if (packet == nullptr || section > 3) { | |
| if (packet == nullptr || section > DNSResourceRecord::ADDITIONAL) { |
pdns/dnsdistdist/dnsdist-lua-ffi.cc
Outdated
|
|
||
| bool dnsdist_ffi_dnspacket_parse(const char* packet, size_t packetSize, dnsdist_ffi_dnspacket_t** out) | ||
| { | ||
| if (out == nullptr || packetSize < sizeof(dnsheader)) { |
There was a problem hiding this comment.
Suggested change
| if (out == nullptr || packetSize < sizeof(dnsheader)) { | |
| if (packet == nullptr || out == nullptr || packetSize < sizeof(dnsheader)) { |
chbruyand
reviewed
Oct 6, 2022
chbruyand
approved these changes
Oct 10, 2022
rgacogne
force-pushed
the
ddist-dnsparser-helpers
branch
from
8beac1d to
3230f6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR provides regular and FFI bindings allowing to look at the DNS records contained in a DNS payload. There is no parsing of the rdata (content) of the DNS records, though, and at this point this is not something we want to add.
Checklist
I have: