Skip to content

retain output when expunging from multiple caches #12077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

christofchen
Copy link
Contributor

Short description

append to the output buffer in expungeByName (instead of overwriting)

Checklist

I have:

  • [X ] read the CONTRIBUTING.md document
  • [ X] compiled this code
  • [ X] tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • [X ] checked that this code was merged to master

This fix addresses #12075

@rgacogne rgacogne self-requested a review October 8, 2022 14:16
@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Oct 8, 2022
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit worried about g_outputBuffer potentially still having some left-over data from the previous command, but it looks like we are careful to clear it between lines, so it should be OK.

@rgacogne rgacogne merged commit 2536452 into PowerDNS:master Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants