dnsdist: Add a new chain of rules triggered after cache insertion #12280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general idea is to be able to store the unedited version into the cache while delivering a different version to the actual client. This is useful when one is sending different answers to different clients, like when dealing with abuse traffic, but still want to be able to cache the initial response from the backend. We already have a chain of rules that are triggered after a cache-hit, but until now we lacked the ability to trigger after getting the response corresponding to a cache-miss.
|
CI failures are unrelated. |
Habbie
reviewed
Dec 9, 2022
| @@ -333,18 +349,30 @@ void setupLuaRules(LuaContext& luaCtx) | |||
| return rulesToString(getTopRules(*rules, top.get_value_or(10)), vars); | |||
| }); | |||
|
|
|||
| luaCtx.writeFunction("getCacheHitResponseRules", [](boost::optional<unsigned int> top) { | |||
There was a problem hiding this comment.
was the intention to fully remove this function (and topCacheHitRules)?
There was a problem hiding this comment.
I intended to rename them, yes. The naming was inconsistent with the existing functions dealing with the other chains of rules, and the documentation was using these names already. I pondered deprecating these but as are mostly used to inspect rules at run-time, I don't think it will break any existing setup.
There was a problem hiding this comment.
Ah! I see the 'new' names in the old docs now. Great :)
Habbie
approved these changes
Dec 9, 2022
omoerbeek
reviewed
Dec 9, 2022
|
|
||
| Return the cache-inserted response rules that matched the most. | ||
|
|
||
| :param int top: How many response rules to return. |
|
|
||
| This function shows the cache-inserted response rules that matched the most. | ||
|
|
||
| :param int top: How many rules to show. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The general idea is to be able to store the unedited version into the cache while delivering a different version to the actual client. This is useful when one is sending different answers to different clients, like when dealing with abuse traffic, but still want to be able to cache the initial response from the backend. We already have a chain of rules that are triggered after a cache-hit, but until now we lacked the ability to trigger after getting the response corresponding to a cache-miss.
Checklist
I have: