dnsdist: Merge the 'main' and 'client' DoH threads in single acceptor mode #12386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are in "single acceptor thread" mode, merge the 'main' and 'client' DoH threads into a single one. We use separate threads to reduce the separate the handling of the HTTP/2 traffic from the DNS handling, to reduce latency, but that does not really make sense on small devices with a single, limited CPU core. On these we prefer using as few threads as possible to reduce the context switches and the memory usage.
rgacogne
force-pushed
the
single-doh-acceptor
branch
from
d7725ba
to
6c1dcaf
Compare
chbruyand
approved these changes
Jan 13, 2023
chbruyand
reviewed
Jan 13, 2023
| { | ||
| // if there was no EDNS, we add it with a large buffer size | ||
| // so we can use UDP to talk to the backend. | ||
| auto dh = const_cast<struct dnsheader*>(reinterpret_cast<const struct dnsheader*>(du->query.data())); |
There was a problem hiding this comment.
Just to be sure, do we already know that data() is at least the size of a dnsheader at this point (otherwise we would not hit that point) ?
There was a problem hiding this comment.
Yes, otherwise it would have been discarded at the beginning of doh_dispatch_query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
When we are in "single acceptor thread" mode, merge the 'main' and 'client' DoH threads into a single one. We use separate threads to reduce the separate the handling of the HTTP/2 traffic from the DNS handling, to reduce latency, but that does not really make sense on small devices with a single, limited CPU core. On these we prefer using as few threads as possible to reduce the context switches and the memory usage.
Note that this pull request builds on #12383 and will have to be rebased.Checklist
I have: