Support OpenSSL 3.0 for ipcipher CA6 encryption/decryption

[fredmorcos]

Short description

Support OpenSSL 3.0 for ipcipher CA6 encryption/decryption. Nothing special here, use OpenSSL 3.0's EVP_CIPHER_* instead of the deprecated AES_* API but continue to support the deprecated OpenSSL 1.1.1 API.

Checklist

I have:

• read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[rgacogne]

That's absolutely not on you but it looks like the new code is three times slower than the existing one when doing one round of encryption/decryption. I guess that's likely because the new API requires at least two allocations per round while the deprecated one did no allocation at all..

[fredmorcos]

That's absolutely not on you but it looks like the new code is three times slower than the existing one when doing one round of encryption/decryption. I guess that's likely because the new API requires at least two allocations per round while the deprecated one did no allocation at all..

Perhaps we can reuse context objects. But I would attempt to do that after all the openssl3 updates so that we at least have a basis of "correctness" to base that change on.

[rgacogne]

Perhaps we can reuse context objects. But I would attempt to do that after all the openssl3 updates so that we at least have a basis of "correctness" to base that change on.

Agreed, and even then I would not worry too much about it until we measure an actual regression. I don't know how many people actually use that ipcipher code in production nowadays.

[rgacogne]

Looks good, nice work!