dnsdist: Add the ability to change the qname and owner names in DNS packets #12417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
force-pushed
the
ddist-async-alternate-name
branch
from
7464710 to
b84ac3b
Compare
rgacogne
force-pushed
the
ddist-async-alternate-name
branch
from
b84ac3b to
56287dc
Compare
rgacogne
changed the title
7 tasks
omoerbeek
reviewed
Jan 26, 2023
Yes and no, the gist of it is that dnsdist's FFI API is not documented at all, which is not great. It's also very low-level, by design, so it's hard to document in a meaningful way, but in the future we should do better than no documentation at all. |
|
Looked good from what I read |
omoerbeek
approved these changes
Jan 31, 2023
rgacogne
added a commit
to rgacogne/pdns
that referenced
this pull request
Jan 31, 2023
I removed the pdns_string_view alias in PowerDNS#12417 as it was no longer used, but merging PowerDNS#11511 actually reintroduced it, breaking the build.
7 tasks
omoerbeek
pushed a commit
to omoerbeek/pdns
that referenced
this pull request
Feb 10, 2023
I removed the pdns_string_view alias in PowerDNS#12417 as it was no longer used, but merging PowerDNS#11511 actually reintroduced it, breaking the build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
In some setups, we might need to get the result for a different qname and change the response to set the owner names of the records matching the changed qname back to the initial qname. Note that this is brittle and should only be used in very specific cases.
This PR is based on top of #12388 and will have to be rebased.Checklist
I have: