Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Gracefully handle a failure to create a TLS server context #12435

Merged
merged 2 commits into from
Jan 20, 2023
Merged

dnsdist: Gracefully handle a failure to create a TLS server context #12435

merged 2 commits into from
Jan 20, 2023

Conversation

rgacogne
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jan 18, 2023
@rgacogne rgacogne requested a review from fredmorcos January 18, 2023 14:01
fredmorcos
fredmorcos approved these changes Jan 18, 2023
View reviewed changes
pdns/libssl.cc Outdated Show resolved Hide resolved
pdns/libssl.cc Outdated Show resolved Hide resolved
@rgacogne
dnsdist: Use pdns::OpenSSL::error and decltype()
96152c3 
As suggested by Fred (thanks!).
@rgacogne rgacogne merged commit b03958c into PowerDNS:master Jan 20, 2023
@rgacogne rgacogne deleted the ddist-failure-server-ctx branch January 20, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredmorcos fredmorcos fredmorcos approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @fredmorcos