Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add an option for unauthenticated access to the dashboard #12474

Merged
merged 2 commits into from
Jan 26, 2023
Merged

dnsdist: Add an option for unauthenticated access to the dashboard #12474

merged 2 commits into from
Jan 26, 2023

Conversation

rgacogne
Copy link
Member

Short description

Closes #10360.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jan 25, 2023
chbruyand
chbruyand approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rgacogne rgacogne merged commit d311a65 into PowerDNS:master Jan 26, 2023
@rgacogne rgacogne deleted the ddist-dashboard-no-auth branch January 26, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

@fredmorcos fredmorcos Awaiting requested review from fredmorcos

@omoerbeek omoerbeek Awaiting requested review from omoerbeek

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.

allow unauthenticated access to dashboard (readonly)
2 participants
@rgacogne @chbruyand