Skip to content

dnsdist: Fail if we can't check the configuration file #12481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2023
Merged

dnsdist: Fail if we can't check the configuration file #12481

merged 4 commits into from
Jan 30, 2023

Conversation

rgacogne
Copy link
Member

Short description

Closes #7611.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Jan 26, 2023
@rgacogne rgacogne requested review from Habbie and omoerbeek January 26, 2023 17:18
Habbie
Habbie reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor doc nits, otherwise good

@rgacogne rgacogne requested a review from Habbie January 27, 2023 17:37
@rgacogne rgacogne force-pushed the dnsdist-check-config branch from 7760eb6 to af1e501 Compare January 30, 2023 10:40
@rgacogne
Copy link
Member Author

Rebased to fix a conflict.

@rgacogne rgacogne merged commit 7e50155 into PowerDNS:master Jan 30, 2023
@rgacogne rgacogne deleted the dnsdist-check-config branch January 30, 2023 13:25
@Habbie Habbie mentioned this pull request Jan 31, 2023
Merged
8 tasks
@rgacogne rgacogne mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

@omoerbeek omoerbeek Awaiting requested review from omoerbeek

@Habbie Habbie Awaiting requested review from Habbie

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.

dnsdist: --config-check returns returncode 0 for non-existing config file
3 participants
@rgacogne @Habbie @chbruyand