Skip to content

dnsdist: Refactor 'cannot be used at runtime' handling #12492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

rgacogne
Copy link
Member

Short description

I did not manage to avoid repeating the function name, unfortunately, without writing something terribly ugly (mixing function-like macros with lambdas), so for now this will have to do.
Closes #11894.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

I did not manage to avoid repeating the function name, unfortunately,
without writing something terribly ugly (mixing function-like macros
with lambdas), so for now this will have to do.
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rgacogne rgacogne merged commit 629b66c into PowerDNS:master Feb 2, 2023
@rgacogne rgacogne deleted the ddist-cannot-be-used-at-runtime branch February 2, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: Refactor 'cannot be used at runtime' configuration directives
2 participants