Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate code in xdp #12518

Merged
merged 1 commit into from
Feb 8, 2023
Merged

remove duplicate code in xdp #12518

merged 1 commit into from
Feb 8, 2023

Conversation

Y7n05h
Copy link
Contributor

@Y7n05h Y7n05h commented Feb 8, 2023

Short description

Remove duplicate code.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Y7n05h
Copy link
Contributor Author

Y7n05h commented Feb 8, 2023

Tip: Please don't use clang15 when reviewing this PR. Otherwise you will get a compilation error (see iovisor/bcc#4467 for details).
Code that triggers bugs in bcc was merged in #11020.

@rgacogne rgacogne self-requested a review February 8, 2023 10:54
@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Feb 8, 2023
@rgacogne rgacogne merged commit ce2bc84 into PowerDNS:master Feb 8, 2023
@rgacogne
Copy link
Member

rgacogne commented Feb 8, 2023

It's much cleaner that way indeed, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Y7n05h @rgacogne