Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add support for metadata in protobuf messages #12520

Merged
merged 5 commits into from
Feb 16, 2023
Merged

dnsdist: Add support for metadata in protobuf messages #12520

merged 5 commits into from
Feb 16, 2023

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Feb 8, 2023 •
edited
Loading

Short description

Closes #9335.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Feb 8, 2023
@rgacogne rgacogne requested a review from chbruyand February 13, 2023 09:19
chbruyand
chbruyand reviewed Feb 13, 2023
View reviewed changes
pdns/dnsdistdist/docs/rules-actions.rst Outdated Show resolved Hide resolved
pdns/dnsdistdist/docs/rules-actions.rst Outdated Show resolved Hide resolved
pdns/dnsdist-protobuf.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne force-pushed the ddist-protobuf-meta branch from 051d33a to 30b91a6 Compare February 14, 2023 10:08
@rgacogne
Copy link
Member Author

I pushed a new commit using repeated strings instead of concatenating values into a single strings, and rebased on the current master to (hopefully) have a working CI.

@rgacogne
Copy link
Member Author

I pushed two new commits:

  • no longer add a traiing : after a tag key when the value is empty, which is nicer to read
  • new option to export dnsdist tags in the Protocol Buffer tags field as well, in addition to the Meta field

@rgacogne rgacogne requested a review from chbruyand February 15, 2023 16:08
chbruyand
chbruyand approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last changes lgtm

@rgacogne rgacogne merged commit f340f32 into PowerDNS:master Feb 16, 2023
@rgacogne rgacogne deleted the ddist-protobuf-meta branch February 16, 2023 08:31
@dmachard dmachard mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojas wojas wojas left review comments

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.

Add User-Agent: logging data to protobuf
3 participants
@rgacogne @wojas @chbruyand