Skip to content

dnsdist: Add support for custom prometheus names in custom metrics #12553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

dnsdist: Add support for custom prometheus names in custom metrics #12553

merged 1 commit into from
Feb 16, 2023

Conversation

rgacogne
Copy link
Member

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Feb 15, 2023
@rgacogne rgacogne requested a review from wojas February 15, 2023 11:32
@rgacogne
Copy link
Member Author

Build and test everything / test-recursor-regression (tsan) (pull_request) Failing after 13m

This is unrelated to this PR (the remote end closed the DoT connection).

chbruyand
chbruyand approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rgacogne rgacogne merged commit db96144 into PowerDNS:master Feb 16, 2023
@rgacogne rgacogne deleted the ddist-custom-metrics-prom-name branch February 16, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

@wojas wojas Awaiting requested review from wojas

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @chbruyand