Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Skip signal-unsafe logging when we are about to exit, with TSAN #12587

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

rgacogne
Copy link
Member

Short description

TSAN is rightfully unhappy about this:

WARNING: ThreadSanitizer: signal-unsafe call inside of a signal

This is not a real problem for us, as the worst case is that we crash trying to exit, but let's try to avoid the warnings in our tests.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

TSAN is rightfully unhappy about this:
```
WARNING: ThreadSanitizer: signal-unsafe call inside of a signal
```

This is not a real problem for us, as the worst case is that
we crash trying to exit, but let's try to avoid the warnings
in our tests.
Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to set a flag and the check for that flag, but this is OK for now.

@rgacogne rgacogne merged commit c9653de into PowerDNS:master Feb 24, 2023
@rgacogne rgacogne deleted the ddist-no-tsan-signal-warning branch February 24, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants