Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist-protobuf: fix compilation with DoH disabled #12588

Merged
merged 1 commit into from
Feb 24, 2023
Merged

dnsdist-protobuf: fix compilation with DoH disabled #12588

merged 1 commit into from
Feb 24, 2023

Conversation

AdamMajer
Copy link
Contributor

Short description

When DoH is disabled, protobuf is trying to access unavailable struct fields. Don't include these in the protobuf messages since they are not available.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

rgacogne
rgacogne approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Feb 24, 2023
@rgacogne rgacogne merged commit 370cc5d into PowerDNS:master Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamMajer @rgacogne