YaHTTP: Better detection of whether C++11 features are available #12589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version relied on having `HAVE_CXX11` defined, which is not true when you are compiling with C++17, for example, even though the C++11 features are available (`HAVE_CXX17` is defined but that does not help).
|
There's also cmouse/yahttp#26 , which provides a more fundamental approach. |
|
That would indeed be better, but I would prefer not diverging too much from upstream, so unless we feel 26 might be merged quickly I would prefer merging this one in the meantime, especially since it was already merged upstream. |
|
Yes, agreed. |
omoerbeek
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The previous version relied on having
HAVE_CXX11defined, which is not true when you are compiling with C++17, for example, even though the C++11 features are available (HAVE_CXX17is defined but that does not help).I'll open a pull request in the YaHTTP repo as well.
Checklist
I have: