Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Only increment the 'servfail-responses' metric on backend responses #12592

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

rgacogne
Copy link
Member

Short description

The fix is very similar to the one in #12590 but I prefer not to rely on the latency metric, and explicitly tells whether the response is coming from a backend instead.
I added regression tests to make sure we don't break that again in the future.

Reported by @phonedph1 (many thanks!).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

…sponses

Reported by phonedph1 (many thanks!).
@rgacogne rgacogne merged commit 112aefd into PowerDNS:master Feb 27, 2023
@rgacogne rgacogne deleted the ddist-servfail-metric branch February 27, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants