Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Use the correct source address when harvesting failed #12641

Merged
merged 1 commit into from
Mar 14, 2023
Merged

dnsdist: Use the correct source address when harvesting failed #12641

merged 1 commit into from
Mar 14, 2023

Conversation

rgacogne
Copy link
Member

Short description

It is a slightly different issue than #12581 because we cannot harvest the original destination address on a loopback interface, so the code path is a bit different.
Fixes #12640

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Mar 11, 2023
@rgacogne rgacogne requested review from chbruyand and omoerbeek March 13, 2023 08:35
@rgacogne rgacogne merged commit ab97308 into PowerDNS:master Mar 14, 2023
@rgacogne rgacogne deleted the ddist-src-not-harvested-loopback branch March 14, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

@omoerbeek omoerbeek Awaiting requested review from omoerbeek

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.

dnsdist 1.8.0-rc2 wrong source address on response for non-127.0.0.1 loopback
2 participants
@rgacogne @chbruyand