Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add metrics for health-check failures #13009

Merged
merged 2 commits into from
Jul 11, 2023
Merged

dnsdist: Add metrics for health-check failures #13009

merged 2 commits into from
Jul 11, 2023

Conversation

rgacogne
Copy link
Member

Short description

Closes #12846.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.9 milestone Jul 10, 2023
@rgacogne rgacogne requested review from omoerbeek and fredmorcos July 10, 2023 12:20
@rgacogne rgacogne force-pushed the ddist-heathcheck-metrics branch from 69aee03 to da73e6b Compare July 10, 2023 14:35
omoerbeek
omoerbeek reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two questions.

@rgacogne rgacogne merged commit 29d9168 into PowerDNS:master Jul 11, 2023
@rgacogne rgacogne deleted the ddist-heathcheck-metrics branch July 11, 2023 08:59
@rgacogne rgacogne mentioned this pull request Aug 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

@fredmorcos fredmorcos Awaiting requested review from fredmorcos

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.9
Development

Successfully merging this pull request may close these issues.

dnsdist: metrics to count failures for health-check domain for the backend server
2 participants
@rgacogne @omoerbeek