Repository navigation
ci: Fix various warnings reported by zizmor - #15600
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 15276506433Details
💛 - Coveralls |
CI: added digest (index when possible) for external images used in gh actions
romeroalx
approved these changes
Jun 3, 2025
romeroalx
left a comment
Member
There was a problem hiding this comment.
LGTM!
Triggered some extra tests:
misc-dailies: https://github.com/romeroalx/pdns/actions/runs/15413471349documentation: https://github.com/romeroalx/pdns/actions/runs/15409849996build-and-test-all for different releases: https://github.com/romeroalx/pdns/actions/runs/15409849995Build packages: https://github.com/romeroalx/pdns/actions/runs/15409850059Build images: https://github.com/romeroalx/pdns/actions/runs/15409849993Builder: https://github.com/romeroalx/pdns/actions/runs/15409849992
All tests were correct. A few errors appeared but they seem related to connectivity issues (apt/yum) rather than something that was changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Zizmor1 reports a few warnings when looking at our workflows:
checkout, which is not nice. see Removepersist-credentialsor change the default tofalseactions/checkout#485coveralls, but not for the remaining ones because it's not clear to me how to pin the exact version of a container image, for exampleThis PR needs a very thorough review before being merged, as the changes to several workflows have not been tested!
Checklist
I have: