Remove superfluous gsql queries and stop relying on schema defaults #3037

Merged
merged 4 commits into from Feb 25, 2016

Projects

None yet

2 participants

@pieterlexis
Member

This PR fixes the issues mentioned in #3024:

First off, it replaces these 3 queries:

  • insert-ent-query
  • insert-empty-non-terminal-query
  • insert-ent-order-query

with one new query: insert-empty-non-terminal-order-query

Secondly, the insert-record-query has an extra parameter and some code so the insert-record-order-query could be removed.

The insert-slave-query is also removed by changing the parameters (and some code) to insert-zone-query.

Lastly, the insert-* queries now insert all fields into the database. This way, we don't rely on schema defaults anymore.

Closes #3024

@Habbie Habbie added this to the auth-4-alpha1 milestone Dec 15, 2015
@pieterlexis pieterlexis changed the title from [WIP] Remove superfluous gsql query for ENTs to [WIP] Remove superfluous gsql queries and stop relying on schema defaults Feb 17, 2016
@pieterlexis pieterlexis changed the title from [WIP] Remove superfluous gsql queries and stop relying on schema defaults to Remove superfluous gsql queries and stop relying on schema defaults Feb 17, 2016
@pieterlexis
Member

Renamed PR, edited description. Review welcome!

@pieterlexis pieterlexis merged commit 19a4ce8 into PowerDNS:master Feb 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pieterlexis pieterlexis deleted the pieterlexis:issue-3024-ENT-cleanups branch Feb 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment