New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Document toString() aliases. Add TCPRule. Make AnyTCRule set TC only over UDP #3251

Merged
merged 2 commits into from Jan 17, 2016

Conversation

Projects
None yet
3 participants
@rgacogne
Member

rgacogne commented Jan 17, 2016

  • For maximum compatibility with PowerDNS Lua scripts, I have recently added toString() and toStringWithPort() aliases, but forgot to document them
  • Add TCPRule() to be able to match queries based on the protocol they were received over
  • Make addAnyTCRule set TC=1 for ANY queries received on UDP, but not on TCP, as suggested by Greg on the dnsdist mailing-list (thanks!)
@ahupowerdns

This comment has been minimized.

Member

ahupowerdns commented Jan 17, 2016

I was just pondering the need for all this! Good stuff!

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-any-tcp branch from e4f305f to 490a29b Jan 17, 2016

ahupowerdns added a commit that referenced this pull request Jan 17, 2016

Merge pull request #3251 from rgacogne/dnsdist-any-tcp
dnsdist: Document toString() aliases. Add TCPRule. Make AnyTCRule set TC only over UDP

@ahupowerdns ahupowerdns merged commit 4e47c09 into PowerDNS:master Jan 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-any-tcp branch Jan 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment