Don't log authentication errors before sending HTTP basic auth challenge #3255

Merged
merged 1 commit into from Jan 19, 2016

Projects

None yet

3 participants

@janeczku

fixes #3254

@janeczku janeczku changed the title from Don't throw authentication errors before sending HTTP basic auth challenge to Don't log authentication errors before sending HTTP basic auth challenge Jan 18, 2016
@stbuehler
Contributor

You also change the order in which 405 (Method not allowed) and 401 (Unauthorized) are returned. Please restrict your changes to what the commit messages says :)

Maybe instead of duplicating the whole 401 block you could just make the errlog call conditional on req->headers.find("authorization") != req->headers.end()

@rgacogne rgacogne merged commit 972d8c6 into PowerDNS:master Jan 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@janeczku janeczku deleted the janeczku:auth-basic branch Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment