New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add incfiles and src_js/ to dnsdist dist tarball #3317

Merged
merged 1 commit into from Jan 29, 2016

Conversation

Projects
None yet
2 participants
@tjikkun
Contributor

tjikkun commented Jan 28, 2016

This allows to regenerate the js files

@rgacogne

This comment has been minimized.

Member

rgacogne commented Jan 29, 2016

Hi Sander,
Thank you, could you just fix the indentation? Otherwise this looks fine to me.

add incfiles and src_js/ to dnsdist dist tarball
This allows to regenerate the js files

@tjikkun tjikkun force-pushed the tjikkun:add_to_dist branch from 26d2d77 to babc4ba Jan 29, 2016

@tjikkun

This comment has been minimized.

Contributor

tjikkun commented Jan 29, 2016

Heh that is some weird indentation :)
Should we go with tabs or spaces? "Let's do both"
Anyway, now mine is the same.

@rgacogne

This comment has been minimized.

Member

rgacogne commented Jan 29, 2016

Thank you! And we are indeed not always consistent, we need to work on that!

rgacogne added a commit that referenced this pull request Jan 29, 2016

Merge pull request #3317 from tjikkun/add_to_dist
add incfiles and src_js/ to dnsdist dist tarball

@rgacogne rgacogne merged commit af813d9 into PowerDNS:master Jan 29, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment