Dnsdist check config #3412
Merged
Dnsdist check config #3412
Conversation
This allows testing of the configuration before one will try to restart dnsdist with a broken config. Additionally, add tests to confirm the config check still works.
This comment has been minimized.
This comment has been minimized.
|
-c is --client |
| if (g_cmdLine.checkConfig) { | ||
| setupLua(true, g_cmdLine.config); | ||
| // No exception was thrown | ||
| infolog("Configuration '%s' OK!", g_cmdLine.config); |
rgacogne
Feb 19, 2016
Member
Just one thing, setupLua() outputs a warning but does not throw an exception if the configuration file does not exist. I believe that's fine, but that means we will gladly validate a non-existent file, which might not be what you had in mind.
Just one thing, setupLua() outputs a warning but does not throw an exception if the configuration file does not exist. I believe that's fine, but that means we will gladly validate a non-existent file, which might not be what you had in mind.
pieterlexis
Feb 22, 2016
Author
Member
An empty config is a valid config was my reasoning :)
An empty config is a valid config was my reasoning :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This allows testing of the configuration before one will try to restart
dnsdist with a broken config. Additionally, add tests to confirm the
config check still works.