Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDnsdist check config #3412
Conversation
pieterlexis
added some commits
Feb 19, 2016
This comment has been minimized.
This comment has been minimized.
mind04
commented on docs/manpages/dnsdist.1.md in 5efcfa6
Feb 19, 2016
|
-c is --client |
rgacogne
reviewed
Feb 19, 2016
| if (g_cmdLine.checkConfig) { | ||
| setupLua(true, g_cmdLine.config); | ||
| // No exception was thrown | ||
| infolog("Configuration '%s' OK!", g_cmdLine.config); |
This comment has been minimized.
This comment has been minimized.
rgacogne
Feb 19, 2016
Member
Just one thing, setupLua() outputs a warning but does not throw an exception if the configuration file does not exist. I believe that's fine, but that means we will gladly validate a non-existent file, which might not be what you had in mind.
This comment has been minimized.
This comment has been minimized.
rgacogne
added
enhancement
dnsdist
labels
Feb 19, 2016
added a commit
that referenced
this pull request
Feb 21, 2016
ahupowerdns
merged commit e09c0df
into
PowerDNS:master
Feb 21, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
pieterlexis
deleted the
pieterlexis:dnsdist-check-config
branch
Feb 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
pieterlexis commentedFeb 19, 2016
This allows testing of the configuration before one will try to restart
dnsdist with a broken config. Additionally, add tests to confirm the
config check still works.