Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client operation improvements for dnsdist #3440

Merged

Conversation

@pieterlexis
Copy link
Member

@pieterlexis pieterlexis commented Feb 24, 2016

These commits allow the user to specify the dnsdist instance to connect to on the command line and what key to use.

pieterlexis added 4 commits Feb 24, 2016
This will allow you to connect to any dnsdist server by setting the IP
on the commandline
Allow connecting as a client and have encrypted connections
@pieterlexis
Copy link
Member Author

@pieterlexis pieterlexis commented Feb 24, 2016

@rgacogne: ready for review

@@ -1199,6 +1202,7 @@ try
}

#endif
ComboAddress clientAddress = ComboAddress();

This comment has been minimized.

@rgacogne

rgacogne Feb 25, 2016
Member

Just a nit, perhaps clientAddress could be a member of g_cmdLine?

This comment has been minimized.

@pieterlexis

pieterlexis Feb 25, 2016
Author Member

not really, this is because I overload the argv arguments usually used for the backend servers here

This comment has been minimized.

@rgacogne

rgacogne Feb 25, 2016
Member

Sure, I had something like 1 in mind, but I'm ok either way.

This comment has been minimized.

@pieterlexis

pieterlexis Feb 26, 2016
Author Member

I was pondering this last night and it might be cleaner to do it that way yes.

@ahupowerdns
Copy link
Member

@ahupowerdns ahupowerdns commented Mar 2, 2016

so should this be merged or does @rgacogne have a better pull up his sleeve?

@pieterlexis
Copy link
Member Author

@pieterlexis pieterlexis commented Mar 2, 2016

this works fine, we can always make this prettier later

ahupowerdns added a commit that referenced this pull request Mar 2, 2016
Client operation improvements for dnsdist
@ahupowerdns ahupowerdns merged commit 29fc818 into PowerDNS:master Mar 2, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pieterlexis pieterlexis deleted the pieterlexis:dnsdist-client-improvements branch Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.