Client operation improvements for dnsdist #3440

merged 4 commits into from Mar 2, 2016


None yet

3 participants


These commits allow the user to specify the dnsdist instance to connect to on the command line and what key to use.

pieterlexis added some commits Feb 24, 2016
@pieterlexis pieterlexis ComboAddress: add '!=' operator
And tests.
@pieterlexis pieterlexis dnsdist: allow setting server IP with -c
This will allow you to connect to any dnsdist server by setting the IP
on the commandline
@pieterlexis pieterlexis dnsdist: add commandline option for key
Allow connecting as a client and have encrypted connections
@pieterlexis pieterlexis dnsdist: fix typo in manpage 0badda9

@rgacogne: ready for review

@rgacogne rgacogne commented on the diff Feb 25, 2016
@@ -1199,6 +1202,7 @@ try
+ ComboAddress clientAddress = ComboAddress();
rgacogne Feb 25, 2016 Member

Just a nit, perhaps clientAddress could be a member of g_cmdLine?

pieterlexis Feb 25, 2016 Member

not really, this is because I overload the argv arguments usually used for the backend servers here

rgacogne Feb 25, 2016 Member

Sure, I had something like 1 in mind, but I'm ok either way.

pieterlexis Feb 26, 2016 Member

I was pondering this last night and it might be cleaner to do it that way yes.


so should this be merged or does @rgacogne have a better pull up his sleeve?


this works fine, we can always make this prettier later

@ahupowerdns ahupowerdns merged commit 29fc818 into PowerDNS:master Mar 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
@pieterlexis pieterlexis deleted the pieterlexis:dnsdist-client-improvements branch Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment