Improve compatibility for old compilers & libs in MTasker #3472

Merged
merged 5 commits into from Feb 28, 2016

Projects

None yet

3 participants

@nlyan
Contributor
nlyan commented Feb 28, 2016

Fixes MTasker (recursor) build against GCC 4.7 and Boost versions <= 1.51. With respect to the latter we fallback automagically to System V context switching.

Tested against the following:

  • Debian Wheezy (GCC 4.7, Boost 1.49)
  • Debian Jessie (GCC 4.9, Boost 1.55)
  • Arch Linux (GCC 5.3, Boost 1.60)
@nlyan
Contributor
nlyan commented Feb 28, 2016

Damnit, Travis didn't like my #include hack

@ahupowerdns
Member

@nlyan - I think I fixed the travis make dist issue. But could you rebase?

@rubenk rubenk and 1 other commented on an outdated diff Feb 28, 2016
pdns/recursordist/Makefile.am
@@ -85,7 +86,7 @@ pdns_recursor_SOURCES = \
misc.hh misc.cc \
mplexer.hh \
mtasker.hh \
- mtasker_context.hh mtasker_fcontext.cc \
+ mtasker_context.hh mtasker_context.cc \
@rubenk
rubenk Feb 28, 2016 Contributor

Not wanting to be a PITA, but could you swap these, so source file first, then header?

@nlyan
nlyan Feb 28, 2016 Contributor

Done

@rubenk
rubenk commented on 7158b2f Feb 28, 2016

This looks good, nice work!

@ahupowerdns ahupowerdns merged commit c199c34 into PowerDNS:master Feb 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nlyan nlyan deleted the nlyan:mtcleanup branch Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment