make second argument to pdnslog optional #3502

Merged
merged 1 commit into from Mar 4, 2016

Projects

None yet

3 participants

@tfarina
Contributor
tfarina commented Mar 3, 2016

This patch makes the |loglevel| parameter for pdnslog in Lua, optional.
If not specified the default log level will be Warning.

Fixes #3487

@ahupowerdns
Member

@tfarina - did this compile for you? It doesn't on Travis, your Logger::LOG_WARNING does not exist there. Should probably be Logger::Warning.

@tfarina
Contributor
tfarina commented Mar 4, 2016

Yeah, actually it didn't even build the file for me. I ran configure + make, but looks like this lua file was not included?

@tfarina
Contributor
tfarina commented Mar 4, 2016

As I was not familiar with the build system and the targets that I should be building, I missed up.
I apologize for that. I have fixed it now, and I'm just waiting for the build to finish to upload a buildable patch.

@tfarina tfarina make second argument to pdnslog optional
This patch makes the |loglevel| parameter for pdnslog in Lua, optional.
If not specified the default log level will be Warning.

Fixes #3487
fceabff
@Habbie
Member
Habbie commented Mar 4, 2016

@tfarina thank you! Next time please indicate clearly if the work is actually untested, saves everybody time!

@tfarina
Contributor
tfarina commented Mar 4, 2016

For the record and posterity, in order to build it I had to:

$ cd ./pdns/recursordist
$ ./bootstrap
$ ./configure

And then, obviously:

$ make

@ahupowerdns ahupowerdns merged commit a5e9dee into PowerDNS:master Mar 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment