New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Prevent EOF error for empty console response w/o sodium #3594

Merged
merged 1 commit into from Mar 20, 2016

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Mar 18, 2016

Prevent the "Fatal error: EOF while reading message" error when
the server sends an empty response to a single console command.
It was caused by calling readn2() for a 0-sized read.
When libsodium support is enabled, padding prevents 0-sized
responses anyway.

dnsdist: Prevent EOF error for empty console response w/o sodium
Prevent the "Fatal error: EOF while reading message" error when
the server send an empty response to a single console command.
It was caused by calling `readn2()` for a 0-sized read.
When libsodium support is enabled, padding prevents 0-sized
responses anyway.

@rgacogne rgacogne added the dnsdist label Mar 18, 2016

ahupowerdns added a commit that referenced this pull request Mar 20, 2016

Merge pull request #3594 from rgacogne/dnsdist-single-console-command
dnsdist: Prevent EOF error for empty console response w/o sodium

@ahupowerdns ahupowerdns merged commit 1bf3b69 into PowerDNS:master Mar 20, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-single-console-command branch Mar 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment