dnsdist: Prevent dangling TCP fd in case setupTCPDownstream() fails #3634
Conversation
Remove the closed socket descriptor from the sockets map. Otherwise, if an exception occurs in setupTCPDownstream(), we might try to use it and close it again later, not knowing it has been reassigned to another socket or, worse, to a TCP acceptor pipe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Remove the closed socket descriptor from the
socketsmap.Otherwise, if an exception occurs in
setupTCPDownstream(), we mighttry to use it and close it again later, not knowing it has been
reassigned to another socket or, worse, to a TCP acceptor pipe.
This might fix #3560.