API: clean up cryptokeys resource #3656

Merged
merged 1 commit into from Apr 8, 2016

Projects

None yet

2 participants

@zeha
Collaborator
zeha commented Apr 4, 2016

Treat domain not found as a normal not found; treat all keys
absent for single resource request as a normal not found;
return an object instead of a single-valued list for single
resource requests and rename "content" to "privatekey"
and don't re-read the key from the backend.

Also share UeberBackend with DNSSECKeeper to avoid extra
backend connection.

Unfortunately, without support for creating keys, no tests are possible.

@zeha zeha API: clean up cryptokeys resource
Treat domain not found as a normal not found; treat all keys
absent for single resource request as a normal not found;
return an object instead of a single-valued list for single
resource requests and rename "content" to "privatekey"
and don't re-read the key from the backend.

Also share UeberBackend with DNSSECKeeper to avoid extra
backend connection.
29704f6
@zeha zeha added auth defect web labels Apr 4, 2016
@Habbie Habbie merged commit 7a5fdbd into PowerDNS:master Apr 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zeha zeha deleted the zeha:api-cryptokey-cleanup branch Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment