Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Add support for systemd-notify #3677
Conversation
pieterlexis
force-pushed the
pieterlexis:dnsdist-systemd-notify-support
branch
from
f08bdf6
to
ec22bbb
Apr 7, 2016
This comment has been minimized.
This comment has been minimized.
|
Nice! Perhaps we could also fallback to 'simple' if systemd support is not available, like weakforced does since 1? |
rgacogne
added
enhancement
dnsdist
labels
Apr 8, 2016
This comment has been minimized.
This comment has been minimized.
|
After pondering this, I feel there is no reason to generate a service file at all if there are no systemd(-dev) libraries installed, as the program is not intended to be run inside of systemd. We can stick a Type=simple service file in the contrib dir and have some documentation about this. |
pieterlexis
force-pushed the
pieterlexis:dnsdist-systemd-notify-support
branch
from
ec22bbb
to
b141d4d
Apr 8, 2016
Habbie
reviewed
Apr 11, 2016
| sock = getenv("NOTIFY_SOCKET"); | ||
| if(sock != NULL) // Are we indeed running inside of systemd? | ||
| g_cmdLine.beSupervised=true; | ||
| #endif |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pieterlexis
Apr 11, 2016
Member
not if your actually running inside systemd. There is no other way (as daemonizing will break systemd's detection of a startup and not being supervised will spawn a console with a closed stdin, leading to program termination) to do this. We could just exit(1) here and print a message asking the user to start with --supervised
Habbie
referenced this pull request
Apr 11, 2016
Open
polish systemd support (watchdog, custom status messages) #3693
rgacogne
reviewed
Apr 11, 2016
| AC_DEFUN([AX_CHECK_SYSTEMD_LIBS], [ | ||
| AC_CHECK_HEADER([systemd/sd-daemon.h], [ | ||
| AC_CHECK_LIB([systemd-daemon], [sd_listen_fds], [libsystemddaemon="y"]) |
This comment has been minimized.
This comment has been minimized.
rgacogne
Apr 11, 2016
Member
This seems to fail on Arch because libsystemd-daemon.so has been merged into libsystemd.so a while ago (looks like it was in version 209).
This comment has been minimized.
This comment has been minimized.
pieterlexis
Apr 12, 2016
Member
Even centos 7's pkg-config mentions it as 'deprecated'. Debian jessie has systemd 215, so I'll just change the systemd-daemon to systemd
Habbie
reviewed
Apr 11, 2016
| # systemd.m4 - Macros to check for and enable systemd -*- Autoconf -*- | ||
| # | ||
| # Copyright (C) 2014 Luis R. Rodriguez <mcgrof@suse.com> | ||
| # |
This comment has been minimized.
This comment has been minimized.
Habbie
Apr 11, 2016
Member
Can we note the origin (including revision) of this file (or whatever we replace it with to fix @rgacogne's report)?
pieterlexis
force-pushed the
pieterlexis:dnsdist-systemd-notify-support
branch
6 times, most recently
from
e26d287
to
0cd2a77
Apr 12, 2016
pieterlexis
added some commits
Apr 12, 2016
pieterlexis
force-pushed the
pieterlexis:dnsdist-systemd-notify-support
branch
from
0cd2a77
to
a1c0a38
Apr 12, 2016
This comment has been minimized.
This comment has been minimized.
|
I fixed up this PR so our packages use this and tested the resulting packages |
pieterlexis commentedApr 7, 2016
We now also install our dnsdist.service file from make install.
Needs review