New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pls discuss: Teeaction: send copy of query to second nameserver, sponge responses #3762

Merged
merged 6 commits into from Apr 26, 2016

Conversation

Projects
None yet
2 participants
@ahupowerdns
Member

ahupowerdns commented Apr 25, 2016

This adds a getStats() too all Actions which is currently empty, but could be exposed via the API so people could query it remotely. I think it makes sense like this but @rgacogne is closed in tune with the architecture of dnsdist post 1.0.0 I think. So please ponder before merging!

ahupowerdns added some commits Apr 25, 2016

if(dq->tcp)
d_tcpdrops++;
else {
d_queries++;

This comment has been minimized.

@rgacogne

rgacogne Apr 25, 2016

Member

Given that this may be called from different threads, perhaps we might want to make d_tcpdrops and d_queries atomic

if(res==0)
continue;
res=recv(d_fd, packet, sizeof(packet), 0);
if(res <= 0)

This comment has been minimized.

@rgacogne

rgacogne Apr 25, 2016

Member

< sizeof(struct dnsheader), otherwise we might be reading garbage below

@ahupowerdns ahupowerdns merged commit fb2e6a1 into PowerDNS:master Apr 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ahupowerdns ahupowerdns deleted the ahupowerdns:teeaction branch Sep 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment