Pls discuss: Teeaction: send copy of query to second nameserver, sponge responses #3762
Conversation
…king the whole daemon when you delete a rule
… for the remotely connected console too
… to an action, add getStats() to give you raw stats
| if(dq->tcp) | ||
| d_tcpdrops++; | ||
| else { | ||
| d_queries++; |
rgacogne
Apr 25, 2016
Member
Given that this may be called from different threads, perhaps we might want to make d_tcpdrops and d_queries atomic
Given that this may be called from different threads, perhaps we might want to make d_tcpdrops and d_queries atomic
pdns/dnsdistdist/dnsrulactions.cc
Outdated
| if(res==0) | ||
| continue; | ||
| res=recv(d_fd, packet, sizeof(packet), 0); | ||
| if(res <= 0) |
rgacogne
Apr 25, 2016
Member
< sizeof(struct dnsheader), otherwise we might be reading garbage below
< sizeof(struct dnsheader), otherwise we might be reading garbage below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This adds a getStats() too all Actions which is currently empty, but could be exposed via the API so people could query it remotely. I think it makes sense like this but @rgacogne is closed in tune with the architecture of dnsdist post 1.0.0 I think. So please ponder before merging!