Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPls discuss: Teeaction: send copy of query to second nameserver, sponge responses #3762
Conversation
ahupowerdns
added some commits
Apr 25, 2016
rgacogne
reviewed
Apr 25, 2016
| if(dq->tcp) | ||
| d_tcpdrops++; | ||
| else { | ||
| d_queries++; |
This comment has been minimized.
This comment has been minimized.
rgacogne
Apr 25, 2016
Member
Given that this may be called from different threads, perhaps we might want to make d_tcpdrops and d_queries atomic
rgacogne
reviewed
Apr 25, 2016
pdns/dnsdistdist/dnsrulactions.cc
Outdated
| if(res==0) | ||
| continue; | ||
| res=recv(d_fd, packet, sizeof(packet), 0); | ||
| if(res <= 0) |
This comment has been minimized.
This comment has been minimized.
rgacogne
Apr 25, 2016
Member
< sizeof(struct dnsheader), otherwise we might be reading garbage below
ahupowerdns
added some commits
Apr 25, 2016
ahupowerdns
merged commit fb2e6a1
into
PowerDNS:master
Apr 26, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
ahupowerdns
deleted the
ahupowerdns:teeaction
branch
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ahupowerdns commentedApr 25, 2016
This adds a getStats() too all Actions which is currently empty, but could be exposed via the API so people could query it remotely. I think it makes sense like this but @rgacogne is closed in tune with the architecture of dnsdist post 1.0.0 I think. So please ponder before merging!