Add a minimum offset parameter to DNSName #3766

Merged
merged 1 commit into from Apr 28, 2016

Projects

None yet

2 participants

@rgacogne
Member

PacketReader does not copy the header part of the DNS message,
therefore DNSName needs to be aware of the minimum valid offset
in order not to follow a pointer to an offset < sizeof(dnsheader),
as other callers expect every non-negative offset to be valid.
Found with American Fuzzy Lop and Address Sanitizer.

@rgacogne rgacogne Add a minimum offset parameter to DNSName
PacketReader does not copy the header part of the DNS message,
therefore DNSName needs to be aware of the minimum valid offset
in order not to follow a pointer to an offset < sizeof(dnsheader),
as other callers expect every non-negative offset to be valid.
Found with American Fuzzy Lop and Address Sanitizer.
83fc9d8
@rgacogne rgacogne added the defect label Apr 26, 2016
@pieterlexis pieterlexis added this to the auth-4-alpha3 milestone Apr 26, 2016
@pieterlexis pieterlexis merged commit 211d968 into PowerDNS:master Apr 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:packetparser-min-offset branch Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment