Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Keep the servers ordered inside pools #3906

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

rgacogne
Copy link
Member

Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a NumberedVector to
be able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.
Close #3903.

@@ -213,7 +213,7 @@ def testRR(self):
"""
Routing: Round Robin

Send 100 A queries to "rr.routing.tests.powerdns.com.",
Send 10 A queries to "rr.routing.tests.powerdns.com.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this change supposed to be in this commit?

@Habbie
Copy link
Member

Habbie commented Jun 3, 2016

One question/nit, otherwise LGTM.

Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a `NumberedVector` to
be able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.
@rgacogne rgacogne merged commit 900f6bb into PowerDNS:master Jun 6, 2016
@rgacogne rgacogne deleted the dnsdist-issue-3903 branch June 6, 2016 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants