New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Keep the servers ordered inside pools #3906

Merged
merged 1 commit into from Jun 6, 2016

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented May 26, 2016

Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a NumberedVector to
be able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.
Close #3903.

@@ -213,7 +213,7 @@ def testRR(self):
"""
Routing: Round Robin
Send 100 A queries to "rr.routing.tests.powerdns.com.",
Send 10 A queries to "rr.routing.tests.powerdns.com.",

This comment has been minimized.

@Habbie

Habbie Jun 3, 2016

Member

Was this change supposed to be in this commit?

@Habbie

This comment has been minimized.

Member

Habbie commented Jun 3, 2016

One question/nit, otherwise LGTM.

dnsdist: Keep the servers ordered inside pools
Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a `NumberedVector` to
be able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.

@rgacogne rgacogne force-pushed the rgacogne:dnsdist-issue-3903 branch from 971e94c to d12cd8e Jun 3, 2016

@rgacogne rgacogne merged commit 900f6bb into PowerDNS:master Jun 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-issue-3903 branch Jun 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment