dnsdist: Keep the servers ordered inside pools #3906

Merged
merged 1 commit into from Jun 6, 2016

Projects

None yet

2 participants

@rgacogne
Member

Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a NumberedVector to
be able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.
Close #3903.

@Habbie Habbie commented on an outdated diff Jun 3, 2016
regression-tests.dnsdist/test_Routing.py
@@ -213,7 +213,7 @@ def testRR(self):
"""
Routing: Round Robin
- Send 100 A queries to "rr.routing.tests.powerdns.com.",
+ Send 10 A queries to "rr.routing.tests.powerdns.com.",
@Habbie
Habbie Jun 3, 2016 Member

Was this change supposed to be in this commit?

@Habbie
Member
Habbie commented Jun 3, 2016

One question/nit, otherwise LGTM.

@rgacogne rgacogne dnsdist: Keep the servers ordered inside pools
Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a `NumberedVector` to
be able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.
d12cd8e
@rgacogne rgacogne merged commit 900f6bb into PowerDNS:master Jun 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rgacogne rgacogne deleted the rgacogne:dnsdist-issue-3903 branch Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment