Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Keep the servers ordered inside pools #3906
Conversation
rgacogne
added
defect
dnsdist
labels
May 26, 2016
Habbie
reviewed
Jun 3, 2016
| @@ -213,7 +213,7 @@ def testRR(self): | ||
| """ | ||
| Routing: Round Robin | ||
| Send 100 A queries to "rr.routing.tests.powerdns.com.", | ||
| Send 10 A queries to "rr.routing.tests.powerdns.com.", |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
One question/nit, otherwise LGTM. |
rgacogne
force-pushed the
rgacogne:dnsdist-issue-3903
branch
from
971e94c
to
d12cd8e
Jun 3, 2016
rgacogne
merged commit 900f6bb
into
PowerDNS:master
Jun 6, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
rgacogne
deleted the
rgacogne:dnsdist-issue-3903
branch
Jun 6, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgacogne commentedMay 26, 2016
Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a
NumberedVectortobe able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.
Close #3903.