dnsdist: Keep the servers ordered inside pools #3906
Merged
Conversation
| @@ -213,7 +213,7 @@ def testRR(self): | |||
| """ | |||
| Routing: Round Robin | |||
| Send 100 A queries to "rr.routing.tests.powerdns.com.", | |||
| Send 10 A queries to "rr.routing.tests.powerdns.com.", | |||
Habbie
Jun 3, 2016
Member
Was this change supposed to be in this commit?
Was this change supposed to be in this commit?
|
One question/nit, otherwise LGTM. |
Several policies expect the servers to be ordered on their 'order'. In addition to that, we keep the servers in a `NumberedVector` to be able to pass them as a Lua table to Lua custom policies, and that means we need to get the numbers right there too, especially when we remove a server from a pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Several policies expect the servers to be ordered on their 'order'.
In addition to that, we keep the servers in a
NumberedVectortobe able to pass them as a Lua table to Lua custom policies, and
that means we need to get the numbers right there too, especially
when we remove a server from a pool.
Close #3903.