Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign updnsdist: Filter on opcode, records count/type, trailing data #3936
Conversation
rgacogne
added
enhancement
dnsdist
labels
Jun 6, 2016
zeha
reviewed
Jun 6, 2016
pdns/dnsparser.cc
Outdated
| for(size_t n = 0; n < numrecords; ++n) { | ||
| dpm.skipLabel(); | ||
| /* const uint16_t dnstype */ dpm.get16BitInt(); |
This comment has been minimized.
This comment has been minimized.
zeha
Jun 6, 2016
Collaborator
i'd suggest not having multi-line comment syntax and actual code on the same line
ahupowerdns
merged commit cead95c
into
PowerDNS:master
Jun 7, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
rgacogne
deleted the
rgacogne:dnsdist-more-filtering-options
branch
Jun 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
rgacogne commentedJun 6, 2016
OpcodeRule()to filter on opcode + DNSOpcode.* Lua valuesTrailingDataRule()to filter queries with trailing dataRecordsCountRule(section, minCount, maxCount)to match onthe number of records in a given section
RecordsTypeCountRule(section, type, minCount, maxCount)tomatch on the number of records of type
typein a given section