dnsdist: Filter on opcode, records count/type, trailing data #3936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `OpcodeRule()` to filter on opcode + DNSOpcode.* Lua values * Add `TrailingDataRule()` to filter queries with trailing data * Add `RecordsCountRule(section, minCount, maxCount)` to match on the number of records in a given section * Add `RecordsTypeCountRule(section, type, minCount, maxCount)` to match on the number of records of type `type` in a given section * Add DNSSection.* Lua values * Add DNSClass.* Lua values
pdns/dnsparser.cc
Outdated
| for(size_t n = 0; n < numrecords; ++n) { | ||
| dpm.skipLabel(); | ||
|
|
||
| /* const uint16_t dnstype */ dpm.get16BitInt(); |
Collaborator
There was a problem hiding this comment.
i'd suggest not having multi-line comment syntax and actual code on the same line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpcodeRule()to filter on opcode + DNSOpcode.* Lua valuesTrailingDataRule()to filter queries with trailing dataRecordsCountRule(section, minCount, maxCount)to match onthe number of records in a given section
RecordsTypeCountRule(section, type, minCount, maxCount)tomatch on the number of records of type
typein a given section