New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement subcommand printing all KSK DS records in pdnsutil (by adapting showZone) #4007

Merged
merged 2 commits into from Dec 5, 2016

Conversation

Projects
None yet
4 participants
@horazont
Contributor

horazont commented Jun 16, 2016

The subcommands prints all KSK DS records of the given zone to stdout. Diagnostics are exclusively printed to stderr, and if the zone is not secured this is fatal.

This is a different approach to the same thing as #4005. Only one of the two should be merged.

if(!dk.isSecuredZone(zone)) {
cout<<"Zone is not actively secured"<<endl;

This comment has been minimized.

@Habbie

Habbie Jun 16, 2016

Member

For show-zone, this should stay cout. Perhaps move the cerr into exportDS and add an else for the cout.

@Habbie

Habbie Jun 16, 2016

Member

For show-zone, this should stay cout. Perhaps move the cerr into exportDS and add an else for the cout.

@Habbie

This comment has been minimized.

Show comment
Hide comment
@Habbie

Habbie Jun 16, 2016

Member

One nit; rest looks good at a -quick- glance. Should get some more review before merge.

Member

Habbie commented Jun 16, 2016

One nit; rest looks good at a -quick- glance. Should get some more review before merge.

@horazont

This comment has been minimized.

Show comment
Hide comment
@horazont

horazont Jun 16, 2016

Contributor

Fixed the nit. The travis build seems to fail for other reasons, as far as I can tell.

Contributor

horazont commented Jun 16, 2016

Fixed the nit. The travis build seems to fail for other reasons, as far as I can tell.

@Habbie Habbie added this to the auth-4.1.0 milestone Jul 7, 2016

@pieterlexis

This comment has been minimized.

Show comment
Hide comment
@pieterlexis

pieterlexis Sep 5, 2016

Member

Has conflicts, could you rebase? Thanks!

Member

pieterlexis commented Sep 5, 2016

Has conflicts, could you rebase? Thanks!

horazont added some commits Jun 16, 2016

Implement subcommand printing all KSK DS records in pdnsutil
The subcommands prints all KSK DS records of the given zone to
stdout. Diagnostics are exclusively printed to stderr, and if the
zone is not secured this is fatal.
@horazont

This comment has been minimized.

Show comment
Hide comment
@horazont

horazont Sep 6, 2016

Contributor

@pieterlexis I rebased, but I cannot test as I do not have a 4.x installation at hand.

Contributor

horazont commented Sep 6, 2016

@pieterlexis I rebased, but I cannot test as I do not have a 4.x installation at hand.

@pieterlexis pieterlexis merged commit cae148f into PowerDNS:master Dec 5, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@horazont horazont deleted the horazont:feature/pdnsutil-export-zone-ds-showZone branch Dec 5, 2016

@ahupowerdns ahupowerdns modified the milestone: auth-4.1.0 Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment