Skip to content

Conversation

@rgacogne
Copy link
Member

No description provided.

* Network related:
* `addLocal(netmask, [true], [false])`: add to addresses we listen on. Second optional parameter sets TCP/IP or not. Third optional parameter sets SO_REUSEPORT when available.
* `setLocal(netmask, [true], [false])`: reset list of addresses we listen on to this address. Second optional parameter sets TCP/IP or not. Third optional parameter sets SO_REUSEPORT when available.
* `addLocal(netmask, [true], [false], [TCP Fast Open queue size])`: add to addresses we listen on. Second optional parameter sets TCP/IP or not. Third optional parameter sets SO_REUSEPORT when available. Last parameter sets the TCP Fast Open queue size, enabling TCP Fast Open when available and the value is larger than 0.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit unrelated to this actual patch: saying 'TCP/IP' here instead of 'TCP' confuses me every time. I know 'TCP/IP' is not -wrong- but maybe we can think about improving this.

@rgacogne
Copy link
Member Author

Added a commit replacing "TCP/IP" by "TCP" in the README.

@Habbie
Copy link
Member

Habbie commented Jul 7, 2016

LGTM

@rgacogne rgacogne merged commit 9c4d43c into PowerDNS:master Aug 1, 2016
@rgacogne rgacogne deleted the dnsdist-tcp-fast-open branch August 1, 2016 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants