New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add server-side TCP Fast Open support #4042

Merged
merged 4 commits into from Aug 1, 2016

Conversation

Projects
None yet
2 participants
@rgacogne
Member

rgacogne commented Jun 25, 2016

No description provided.

@@ -1142,8 +1142,8 @@ Here are all functions:
* member `attachFilter(BPFFilter)`: attach a BPF Filter to this bind
* member `toString()`: print the address this bind listens to
* Network related:
* `addLocal(netmask, [true], [false])`: add to addresses we listen on. Second optional parameter sets TCP/IP or not. Third optional parameter sets SO_REUSEPORT when available.
* `setLocal(netmask, [true], [false])`: reset list of addresses we listen on to this address. Second optional parameter sets TCP/IP or not. Third optional parameter sets SO_REUSEPORT when available.
* `addLocal(netmask, [true], [false], [TCP Fast Open queue size])`: add to addresses we listen on. Second optional parameter sets TCP/IP or not. Third optional parameter sets SO_REUSEPORT when available. Last parameter sets the TCP Fast Open queue size, enabling TCP Fast Open when available and the value is larger than 0.

This comment has been minimized.

@Habbie

Habbie Jun 25, 2016

Member

Nit unrelated to this actual patch: saying 'TCP/IP' here instead of 'TCP' confuses me every time. I know 'TCP/IP' is not -wrong- but maybe we can think about improving this.

@rgacogne

This comment has been minimized.

Member

rgacogne commented Jun 29, 2016

Added a commit replacing "TCP/IP" by "TCP" in the README.

@Habbie

This comment has been minimized.

Member

Habbie commented Jul 7, 2016

LGTM

@rgacogne rgacogne merged commit 9c4d43c into PowerDNS:master Aug 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rgacogne rgacogne deleted the rgacogne:dnsdist-tcp-fast-open branch Aug 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment