Recursor: Add DNSSEC validation statistics #4077

Merged
merged 1 commit into from Jul 6, 2016

Projects

None yet

3 participants

@pieterlexis
Member

Closes #3916

@ahupowerdns ahupowerdns commented on an outdated diff Jul 4, 2016
docs/markdown/recursor/stats.md
@@ -26,6 +26,13 @@ The `rec_control get` command can be used to query the following statistics, eit
* `client-parse-errors`: counts number of client packets that could not be parsed
* `concurrent-queries`: shows the number of MThreads currently running
* `dlg-only-drops`: number of records dropped because of delegation only setting
+* `dnssec-queries`: number of queries received with the DO and/or AD bit set
+* `dnssec-result-bogus`: number of DNSSEC validations that had the Bogus state
+* `dnssec-result-indeterminate`: number of DNSSEC validations that had the Indeterminate state
+* `dnssec-result-insecure`: number of DNSSEC validations that had the Insecure state
+* `dnssec-result-NTA`: number of DNSSEC validations that had the NTA (negative trust anchor) state
@ahupowerdns
ahupowerdns Jul 4, 2016 Member

can you lowercase this? we have no policy on case sensitivity for metrics so for now I'd like to keep all of them lower case

@Habbie Habbie and 1 other commented on an outdated diff Jul 5, 2016
pdns/validate-recursor.cc
if(keys.empty()) {
+ g_stats.dnssecResults[Insecure]++;
return Insecure;
}
@Habbie
Habbie Jul 5, 2016 Member

I see like 6 instances of the ++ plus return - wonder if we can refactor that? a macro maybe?

@pieterlexis
pieterlexis Jul 5, 2016 Member

Changed to an inline function

@Habbie
Member
Habbie commented Jul 5, 2016

One nit, otherwise LGTM

@pieterlexis pieterlexis added this to the rec-4.0.0 milestone Jul 5, 2016
@pieterlexis
Member

could use another review

@pieterlexis pieterlexis merged commit 35bd5f3 into PowerDNS:master Jul 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@pieterlexis pieterlexis deleted the pieterlexis:dnssec-stats branch Jul 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment