New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metadata handlers for HTTP API #4093

Merged
merged 4 commits into from Sep 5, 2016

Conversation

Projects
None yet
5 participants
@commx
Contributor

commx commented Jul 3, 2016

This pull request replaces #4080.

I've also added LUA-AXFR-SCRIPT to the list of metadata entries which cannot be modified via API due to security concerns. As discussed previously, the implementation will reject creation and modification of custom metadata entries. We may choose from three possible options to relax the behavior:

  1. Leave the implementation as-is, rejecting custom metadata entries at all
  2. Accept custom metadata if the configuration option api-allow-custom-metadata is set to yes, reject otherwise
  3. Accept custom metadata at all

@commx commx changed the title from V4.0.x/api domainmetadata to Added metadata handlers for HTTP API Jul 3, 2016

@Habbie Habbie added this to the auth-4.1.0 milestone Jul 7, 2016

Show outdated Hide outdated pdns/ws-auth.cc
@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Jul 11, 2016

Collaborator

Small nit, can't find anything to complain about otherwise.

Looks good!

Collaborator

zeha commented Jul 11, 2016

Small nit, can't find anything to complain about otherwise.

Looks good!

@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Jul 11, 2016

Collaborator

Oh, updating the docs would be heart-warming.

Collaborator

zeha commented Jul 11, 2016

Oh, updating the docs would be heart-warming.

@zeha

This comment has been minimized.

Show comment
Hide comment
@zeha

zeha Sep 5, 2016

Collaborator

IMO good to merge; if I was wrong with rgd. to response codes, this can be fixed afterwards.

Collaborator

zeha commented Sep 5, 2016

IMO good to merge; if I was wrong with rgd. to response codes, this can be fixed afterwards.

@pieterlexis pieterlexis merged commit 1584a1e into PowerDNS:master Sep 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ahupowerdns ahupowerdns modified the milestone: auth-4.1.0 Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment