rec: Don't call `commit()` if we skipped all the records #4096

merged 1 commit into from Jul 8, 2016


None yet

3 participants

rgacogne commented Jul 4, 2016

This should fix the "DNSPacketWriter::commit() called without startRecord ever having been called, but a record was added" part from #4084.

@pieterlexis pieterlexis added this to the rec-4.0.0 milestone Jul 5, 2016
Habbie commented Jul 7, 2016

Closing this in favour of #4119 which includes it.

@Habbie Habbie closed this Jul 7, 2016
@Habbie Habbie reopened this Jul 8, 2016
Habbie commented Jul 8, 2016

After talking to @mind04, merging this and awaiting more work from him for after 4.0.0.

@Habbie Habbie merged commit 5584bfa into PowerDNS:master Jul 8, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
@rgacogne rgacogne deleted the rgacogne:rec-no-empty-commit branch Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment