New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of the cryptokeys REST-API (PUT, POST, DELETE) #4106
Merged
pieterlexis
merged 19 commits into
PowerDNS:master
from
zervnet:feature_rest_api_pull_request
Sep 6, 2016
Merged
Implementation of the cryptokeys REST-API (PUT, POST, DELETE) #4106
pieterlexis
merged 19 commits into
PowerDNS:master
from
zervnet:feature_rest_api_pull_request
Sep 6, 2016
Commits on Sep 6, 2016
-
Update addKey in dnsseckeeper (Closes PowerDNS#706)
- Let addKey return the id of the added key - pdnsutil 'add-zone-key' prints it - pdnsutil 'import-zone-key' prints it - pdnsutil 'import-zone-key-pem' prints it
-
-
-
-
-
-
-
-
More specific error message for addKey
- if bits in addKey are wrong returns "Wrong bit size!"
-
-
-
- id of added key is returned by a reference parameter - return type bool indicates success of adding the key - id is returned as int64_t
-
- Removes redundant code - Uses new addKey() interface - Fixes return values / error messages
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.